Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification failures on MSVC=1, PLATFORM=x86 #296

Closed
2 tasks done
darkk opened this issue Sep 11, 2024 · 0 comments
Closed
2 tasks done

Verification failures on MSVC=1, PLATFORM=x86 #296

darkk opened this issue Sep 11, 2024 · 0 comments

Comments

@darkk
Copy link
Contributor

darkk commented Sep 11, 2024 •
edited
Loading

#293 build highlights the following issues:

  • FNV128 - Verification value 0x000000BA ....... FAIL! (Expected 0xBCAA1426)
  • polymur - Verification value 0xA612032C ....... FAIL! (Expected 0x4F894810)
This was referenced Sep 11, 2024
Merged
Open
darkk added a commit to darkk/smhasher that referenced this issue Sep 26, 2024
@darkk
polymur: fix arm builds, including macos-14-arm64
cde8f69 
polymur Verification value 0xA612032C means that polymur_seed_init()
was not called. Currently, polymur is compiled in unconditionally,
so it should be initialized unconditionally as well.

See rurban#294, rurban#296, rurban#297, rurban#298 and rurban#299.
darkk added a commit to darkk/smhasher that referenced this issue Sep 27, 2024
@darkk
polymur: add missing polymur_seed_init() call
9d52b78 
It fixes arm builds, including macos-14-arm64

polymur Verification value 0xA612032C means that polymur_seed_init()
was not called. Currently, polymur is compiled in unconditionally,
so it should be initialized unconditionally as well.

See rurban#294, rurban#296, rurban#297, rurban#298 and rurban#299.
darkk added a commit to darkk/smhasher that referenced this issue Sep 27, 2024
@darkk
polymur: add missing polymur_seed_init() call
57e2993 
It fixes arm builds, including macos-14-arm64

polymur Verification value 0xA612032C means that polymur_seed_init()
was not called. Currently, polymur is compiled in unconditionally,
so it should be initialized unconditionally as well.

See rurban#294, rurban#296, rurban#297, rurban#298 and rurban#299.
darkk added a commit to darkk/smhasher that referenced this issue Sep 27, 2024
@darkk
polymur: add missing polymur_seed_init() call
dcd1153 
It fixes arm builds, including macos-14-arm64

polymur Verification value 0xA612032C means that polymur_seed_init()
was not called. Currently, polymur is compiled in unconditionally,
so it should be initialized unconditionally as well.

See rurban#294, rurban#296, rurban#297, rurban#298 and rurban#299.
@darkk darkk mentioned this issue Sep 27, 2024
Merged
rurban pushed a commit that referenced this issue Sep 28, 2024
@darkk @rurban
polymur: add missing polymur_seed_init() call
52391b9 
It fixes arm builds, including macos-14-arm64

polymur Verification value 0xA612032C means that polymur_seed_init()
was not called. Currently, polymur is compiled in unconditionally,
so it should be initialized unconditionally as well.

See #294, #296, #297, #298 and #299.
@darkk darkk closed this as completed Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darkk