Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample consensus doesn't give back the correct model #48

Open
vadixidav opened this issue Oct 28, 2021 · 0 comments
Open

Sample consensus doesn't give back the correct model #48

vadixidav opened this issue Oct 28, 2021 · 0 comments
Assignees

Comments

@vadixidav
Copy link
Member

When solving the two-view pose using the EightPoint algorithm in sample consensus, the incorrect model is returned. The cheirality check that occurred in EssentialMatrix::solve_pose was removed when EightPoint was changed to return 4 separate poses, which are only checked based on cosine distance, not cheirality. Cheirality must be checked in the code for the CameraToCamera transformation model residual for it to work correctly.

@vadixidav vadixidav self-assigned this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant