Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook 1.0 #414

Closed
10 of 11 tasks
AndyGauge opened this issue May 16, 2018 · 9 comments
Closed
10 of 11 tasks

Cookbook 1.0 #414

AndyGauge opened this issue May 16, 2018 · 9 comments
Milestone

Comments

@AndyGauge
Copy link
Collaborator

AndyGauge commented May 16, 2018

What will it take for us to call the cookbook 1.0?

First thing: A huge shout out to @budziq and the improvements he has made to the cookbook. I am continually impressed by your effort.

I want to draw a line in the sand that we can release the cookbook. What I think should be in scope of this release:

What I want to keep active (for post 1.0) is:

There are a few PRs that are sitting in the queue. It is going to take some effort to get them to merge after #404 lands. I'd be happy to finish the outstanding work on them and include them in a 1.0 release.

Here's the original discussion at ecosystem-wg.

I'd love some feedback on what you'd like to see done before stamping the Rust Cookbook 1.0

@budziq budziq modified the milestones: impl period, CookBook 1.0 May 16, 2018
@budziq
Copy link
Collaborator

budziq commented May 16, 2018

I fully agree with the idea!

Ive created a milestone to aggregate the issues that most likely should be addressed before 1.0 release.

I'd propose to also address:

optionally:

Not sure if we will be ready for 1.0 then but it should be a good approximation to present to the libs team :)

@AndyGauge
Copy link
Collaborator Author

I've added all those to the original comment. Let's do this thing!

@AndyGauge
Copy link
Collaborator Author

I think we are only missing the updates to the CONTRIBUTING and PR Template to support this purposed 1.0 rewrite.

@AndyGauge
Copy link
Collaborator Author

Actually, we need to determine if the Cookbook will rely on a git version of mdbook or wait until 1.8 drops. Either way, build scripts and README needs to be updated.

@AndyGauge
Copy link
Collaborator Author

In order to build mdbook from master on rust 1.27, rust-lang/cargo#5627 dictates specifying the version (--version 0.1.8-alpha.0) which is brittle. I want to wait until 0.1.8 lands unless rust 1.28 stabilizes first.

@AndyGauge
Copy link
Collaborator Author

0.1.8 landed this morning, I built the branch successfully!

@AndyGauge
Copy link
Collaborator Author

I merged the Reorganize branch #404
Watching for issues in the CI.

@budziq
Copy link
Collaborator

budziq commented Jul 11, 2018

Thanks for pushing this through the finish line @AndyGauge ! 🎉 ❤️

@AndyGauge
Copy link
Collaborator Author

Our imaginary line in the sand is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants