From 022713ca4e3de0229473fc47b42d2eaaad37e503 Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Sun, 5 Nov 2023 10:29:31 +1100 Subject: [PATCH 1/2] Bump MSRV to 1.53.0 and re-enable macos MSRV check Signed-off-by: Jiahao XU --- .github/workflows/main.yml | 6 +++--- Cargo.toml | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4dff9b2d..724b9a61 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -116,14 +116,14 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest] + os: [ubuntu-latest, macos-latest, windows-latest] steps: - uses: actions/checkout@v4 - name: Install Rust run: | - rustup toolchain install 1.46.0 --no-self-update --profile minimal + rustup toolchain install 1.53.0 --no-self-update --profile minimal rustup toolchain install nightly --no-self-update --profile minimal - rustup default 1.46.0 + rustup default 1.53.0 shell: bash - name: Create Cargo.lock with minimal version run: cargo +nightly update -Zminimal-versions diff --git a/Cargo.toml b/Cargo.toml index 89945c56..c7ba95a0 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -16,6 +16,7 @@ readme = "README.md" categories = ["development-tools::build-utils"] exclude = ["/.github"] edition = "2018" +rust-version = "1.53" [dependencies] jobserver = { version = "0.1.16", optional = true } From 3ff23685f8c797e3fc3e601ebe979475dc09c20c Mon Sep 17 00:00:00 2001 From: Jiahao XU Date: Sun, 5 Nov 2023 10:36:54 +1100 Subject: [PATCH 2/2] Disable msrv checking on macos-latest Since 1.53 still can't link on latest macos Signed-off-by: Jiahao XU --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 724b9a61..6f228695 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -116,7 +116,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, windows-latest] steps: - uses: actions/checkout@v4 - name: Install Rust @@ -127,7 +127,7 @@ jobs: shell: bash - name: Create Cargo.lock with minimal version run: cargo +nightly update -Zminimal-versions - - name: Cache downloaded crates since 1.46 is really slow in fetching + - name: Cache downloaded crates since 1.53 is really slow in fetching uses: Swatinem/rust-cache@v2 - run: cargo check --lib - run: cargo check --lib --all-features