Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build path should be canonicalized #227

Open
stevefan1999-personal opened this issue Dec 11, 2024 · 0 comments
Open

Build path should be canonicalized #227

stevefan1999-personal opened this issue Dec 11, 2024 · 0 comments

Comments

@stevefan1999-personal
Copy link

stevefan1999-personal commented Dec 11, 2024

#200

This will still be a relative path if the out dir itself is still relative

Given

    let dst = Config::new("../")
        .out_dir("./")
        .build();

Then

cmake-rs/src/lib.rs

Lines 555 to 559 in 94da9de

let dst = self
.out_dir
.clone()
.unwrap_or_else(|| PathBuf::from(getenv_unwrap("OUT_DIR")));
let build = dst.join("build");

You will notice build variable is still relative. Thus #200 does not work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant