Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve source file rendering speed #1904

Closed
Nemo157 opened this issue Nov 13, 2022 · 2 comments
Closed

Improve source file rendering speed #1904

Nemo157 opened this issue Nov 13, 2022 · 2 comments
Assignees
Labels
A-backend Area: Webserver backend

Comments

@Nemo157
Copy link
Member

Nemo157 commented Nov 13, 2022

After deploying #1842 we have a few high spikes in the /crate/:name/:version/source/* 90th percentile response time

image

I was able to track down one of these from the access logs, https://docs.rs/crate/opus-sys/0.1.2/source/libopus/Makefile.in took 12.25s till first byte when I loaded it. It's surprisingly slow, https://docs.rs/crate/opus-sys/0.1.2/source/libopus/src/opus_encoder.c took <1s and is a similar size.

I'll try and find some time to look into it soon.

@Nemo157 Nemo157 added the A-backend Area: Webserver backend label Nov 13, 2022
@Nemo157 Nemo157 self-assigned this Nov 13, 2022
@syphar
Copy link
Member

syphar commented May 20, 2023

@Nemo157 do you think this is still an issue after the change to the other regex engine?

Looking at the 99th in grafana now I don't see any of these peaks any more?

@Nemo157
Copy link
Member Author

Nemo157 commented May 29, 2023

Agreed this seems to be basically resolved, over the last week the highest spike was 1s

image

@Nemo157 Nemo157 closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend Area: Webserver backend
Projects
None yet
Development

No branches or pull requests

2 participants