Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support targets that lack atomics #622

Closed
ealasu opened this issue Oct 26, 2017 · 4 comments
Closed

Support targets that lack atomics #622

ealasu opened this issue Oct 26, 2017 · 4 comments

Comments

@ealasu
Copy link

ealasu commented Oct 26, 2017

This crate fails to compile on targets that lack atomic primitives, like thumbv6m-none-eabi. Would it make sense to support such targets? One option might be to add a feature called "use_atomic" that's enabled by default, and add #[cfg(feature = use_atomic)] to all the modules that need atomics.

ealasu pushed a commit to ealasu/futures-rs that referenced this issue Oct 29, 2017
ealasu added a commit to ealasu/futures-rs that referenced this issue Oct 29, 2017
@alexcrichton
Copy link
Member

With the closing of #627 I'm going to close this as well

@notgull
Copy link
Contributor

notgull commented Dec 4, 2022

I recently ran into this issue while trying to test out the event-listener crate on Arduino. We may be able to use either portable-atomic or atomic-polyfill to replace the atomics, at least on the lower-level crates (like futures-core, which is the crate that's causing my issue).

@taiki-e
Copy link
Member

taiki-e commented Dec 4, 2022

I would accept a patch to support the portable-atomic.

@notgull
Copy link
Contributor

notgull commented Dec 5, 2022

Opened #2670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants