-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode now supports SnippetTextEdits natively #13229
Comments
I assume this has to wait until the October release is out, if we want to support N-1 versions of VS Code? |
I suppose so? I don't really remember out stance in regards to required VSCode version, but waiting for october sounds reasonable |
It's complicated. We've mostly supported more versions lately when someone at a FAANG asked for that. But they're using a fork of both Code and RA anyway, and I haven't heard much about their rebase schedule lately. |
I guess we could revisit this now? I skimmed the links, but it's not clear to me how well the new Code API matches our extension. |
I'm decently sure that I'm the person in question. In any case, feel free to revisit this now: the sibling team responsible should rolling 1.75 in a few days. I might just ask that #14307 land before your changes land, it'd make the rebase/patching a bit easier on my end (I'm assuming #14307 will land this week). |
Unfortunately, the major difference is that the Code API (along with the related snippet APIs) performs whitespace fixups, and since we preserve the the original whitespace, this leads to extra indentation (see microsoft/language-server-protocol#724 (comment)). There also currently isn't a way to disable these fixups for Thankfully, normal A minor issue of this workaround is that this would technically go against the current specification of the In summary, we probably can't revisit this soon until we can work around the whitespace fixups. |
We should switch to that microsoft/vscode#145374 (comment), #13213 (comment)
The text was updated successfully, but these errors were encountered: