Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Who should have the publish permissions? #168

Closed
JohnTitor opened this issue Feb 8, 2021 · 7 comments
Closed

Who should have the publish permissions? #168

JohnTitor opened this issue Feb 8, 2021 · 7 comments

Comments

@JohnTitor
Copy link
Member

(I'm not sure where to discuss this so opening an issue here.)
It'd be great if we could make a new release at some point. Currently, libc uses git revisions but I'd like to use a version number instead.
https://crates.io/crates/semverver shows only one owner (team), rust-lang-nursery's semver-owners team. But given this is under the rust-lang org now, I think we should add rust-lang-owner as a crate owner like other crates under rust-lang org. And if @Xanewok doesn't have the right to publish, they should also have it (or we could even create a new team and give it the permission).

JohnTitor added a commit to JohnTitor/rust-semverver that referenced this issue Mar 31, 2021
crates.io's version is outdated and we haven't figured out the release process yet.
cc rust-lang#168
bors added a commit that referenced this issue Mar 31, 2021
Update the instruction not to install via crates.io

crates.io's version is outdated and we haven't figured out the release process yet.
cc #168

Closes #184
@Xanewok
Copy link
Member

Xanewok commented Apr 21, 2021

cc @rust-lang/devtools

@Manishearth
Copy link
Member

I don't have admin on rust-lang-nursery so I pinged someone to get ya'll access. And yes, please add rust-lang-owner to it for now. The core team is planning on a proper audit of crate ownership stuff soon and in that there will be a proper process, but for now just add rust-lang-owner for redundancy.

I assume y'all plan to deprecate the crates.io package, yes? Ideally replace it with a placeholder the way Clippy does.

@Manishearth
Copy link
Member

This is done, both of you should be in the team and have publish access

@JohnTitor
Copy link
Member Author

This is done, both of you should be in the team and have publish access

Thanks!

I assume y'all plan to deprecate the crates.io package, yes?

Uhm, actually no (at least I don't). Some still want to install it via crates.io (e.g. #184) and I haven't figured out the best way to fight to rustc private's breaking changes (could we have an automatic release way?). There was a plan to introduce the semverver to rust-lang/rustc but it was closed: rust-lang/rust#73902

@Manishearth
Copy link
Member

Some still want to install it via crates.io (e.g. #184) and I haven't figured out the best way to fight to rustc private's breaking changes (could we have an automatic release way?). There was a plan to introduce the semverver to rust-lang/rustc but it was closed: rust-lang/rust#73902

Ah, makes sense. I would like to eventually see this be shipped in rustup, but that can take time

@dario23
Copy link
Contributor

dario23 commented May 3, 2022

Ah, makes sense. I would like to eventually see this be shipped in rustup, but that can take time

is that more "time for rust-semverver to mature some more" or "time to get all the necessary pull requests done in all necessary places"?

EDIT: found this comment saying "making this a shipped rustup tool requires a lot more buy-in from everyone, and my gut feeling is that this tool is far from ready for that. Hell, it took clippy and RLS forever to do this, and clippy was in a much more mature state when we first started talking about this."

@JohnTitor
Copy link
Member Author

Closing as rust-lang-nursery's semver-owners team works fine to publish, for now (I'd like to maintain the team on rust-lang/team repo though!).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants