Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cfg's for difference between librustdoc and crates.io version #35

Closed
aDotInTheVoid opened this issue Sep 22, 2024 · 2 comments · Fixed by #42
Closed

Use cfg's for difference between librustdoc and crates.io version #35

aDotInTheVoid opened this issue Sep 22, 2024 · 2 comments · Fixed by #42

Comments

@aDotInTheVoid
Copy link
Member

aDotInTheVoid commented Sep 22, 2024

Yeah, we should probably do that either way, to replace the increasing pile of regex we currently use.

Originally posted by @aDotInTheVoid in rust-lang/rfcs#3505 (comment)

@jalil-salame
Copy link
Contributor

jalil-salame commented Oct 20, 2024

#42 reduces the regexes to just deleting the public export:

rustdoc-types/update.sh

Lines 11 to 13 in 44e2899

curl -# https://raw.githubusercontent.com/${user}/${repo}/${branch}/src/rustdoc-json-types/lib.rs \
| sed '/^pub type FxHashMap.*$/d' \
> src/lib.rs

If this is still wanted I can make a PR to rust-lang/rust adding the cfg c:

@aDotInTheVoid
Copy link
Member Author

I think #42 does enough to close this. I don't think it's worth having a reexport-hashmap feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants