We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc-hash
cargo features are supposed to be additive, but rustc-hash isn't.
Consider the case where:
a
rustdoc-types
b
c
Potential fixes
BuildHasher
Crate
I think it's fine to go with 1 for now, but I'm filling this issue so I don't forget this.
Originally reported by @Noratrieb on fediverse
Caused by #42
The text was updated successfully, but these errors were encountered:
No branches or pull requests
cargo features are supposed to be additive, but
rustc-hash
isn't.Consider the case where:
a
depends onrustdoc-types
with default featuresa
relies on the HashMap using the default hasher.b
depends onrustdoc-types
withrustc-hash
feature.c
depends ona
andb
a
againsrustdoc-types
withrustc-hash
enabled.a
fails to compile.Potential fixes
BuildHasher
type that doesn't expose the underlying hashing algo, so changing it is additiverustc-hash
feature, and always use it.3.1. Drop the
rustc-hash
feature, and never use it.Crate
generic over the hasher type.I think it's fine to go with 1 for now, but I'm filling this issue so I don't forget this.
Originally reported by @Noratrieb on fediverse
Caused by #42
The text was updated successfully, but these errors were encountered: