-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not moving the first line comment of blocks #4745
base: rustfmt-2.0.0-rc.2
Are you sure you want to change the base?
Conversation
Thank you! My review queue is pretty backed up right now, but I'm really looking forward to this one. The current behavior that breaks the comment association in these cases is a common source of frustration for users, so there will be a lot of folks that will really appreciate this! |
if true { | ||
/* Sample | ||
comment */ | ||
1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personally, I think it makes more sense to not move the comment one line down. For example, the following use cases
if true { /* this is a supppppppppppppppppppppppppppper
long comment to describe the if condition */
1
}
I just ran into #3255. Is there any way to move this PR forward? It looks like it's labeled A comment in #3887 says:
Does that mean this PR is simply not happening? |
Yes and no. It does mean this specific PR isn't going to get merged given the target branch, but the proposed changes could be merged if someone wants to pick them up and target the correct/master/1.x branch |
I attempted porting this to master: #6265. |
Fixes #3255 , Fixes #3994 , Closing #4715