Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespaced-features to safely bump to MSRV 1.60 #310

Merged
merged 12 commits into from
Mar 25, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Feb 8, 2024

Earlier versions won't see the incompatible updates at all!

@cuviper
Copy link
Member Author

cuviper commented Feb 8, 2024

Note: I have not considered MSRV bumps to be breaking changes, but I have still been very conservative with them to avoid disrupting dependent crates. This bump is not meant to set any new policy, per se -- it's just that this particular feature of 1.60 offers an opportunity to raise MSRV without breaking anyone on older versions.

@cuviper cuviper added this pull request to the merge queue Mar 25, 2024
Merged via the queue into rust-num:master with commit a90d4a6 Mar 25, 2024
4 checks passed
@cuviper cuviper deleted the msrv-1.60 branch May 3, 2024 21:01
@cuviper
Copy link
Member Author

cuviper commented May 3, 2024

Earlier versions won't see the incompatible updates at all!

Now that I have released 0.2.19 (#321), I find that this isn't completely true. Cargo 1.51 through 1.59 will ignore it thanks to the schema version in rust-lang/cargo#9161, backported in rust-lang/cargo#9196, but older Cargo doesn't know to look for that.

So, this bump isn't quite as "free" as I intended, but I think it will be OK. This MSRV 1.60 is still over 2 years old (2022-04-07), and the accidental schema-aware minimum of 1.51 is over 3 years old (2021-03-25). If someone really wants to use even older rustc, they can still manually lock an older version of this crate.

@cuviper cuviper mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant