Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make float::Float::integer_decode DRY #328

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

mtilda
Copy link
Contributor

@mtilda mtilda commented Jun 27, 2024

Blocked by #327

Motivation

The trait method float::Float::integer_decode invokes one of the functions integer_decode_f32 or integer_decode_f64 depending on the implementation. These functions share a lot of code, so I would like to refactor them to use the same underlying source.

Considerations

Status

This is a work in progress, as indicated by the fact that it is a Draft PR. Comments and suggestions are welcome, but not expected.

@mtilda mtilda force-pushed the mtilda/enhance/float-integer-decode branch from 141f91e to 6d30ca6 Compare June 27, 2024 21:22
@mtilda mtilda changed the title Refactor functions integer_decode_f32 and integer_decode_f64 with new macro integer_decode! Make float::Float::integer_decode DRY Jun 27, 2024
@mtilda mtilda force-pushed the mtilda/enhance/float-integer-decode branch from 3971e1c to 0a0a8e5 Compare June 28, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant