Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make float::Float::integer_decode DRY #328

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Make float::Float::integer_decode DRY #328

wants to merge 12 commits into from

Commits on Jun 27, 2024

  1. Add unit tests for trait method float::Float::integer_decode

    @mtilda
    mtilda committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f4967af View commit details
    Browse the repository at this point in the history

  2. Add FIXME related to NaN inputs to 

    `float::Float::integer_decode`
    @mtilda
    mtilda committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    25eb45f View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Fix assertion message in test_integer_decode

    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9232b28 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into mtilda/test/float… 

    …-integer-decode
    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6d33cdb View commit details
    Browse the repository at this point in the history

  3. Update doc strings to clarify which numbers are recoverable

    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a6e2912 View commit details
    Browse the repository at this point in the history

  4. Remove FIXME related to NaN inputs

    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    300a7f9 View commit details
    Browse the repository at this point in the history

  5. Add test cases for subnormal inputs to Float::integer_decode

    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6309a53 View commit details
    Browse the repository at this point in the history

  6. Add comments to mantissa calculation

    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c3b277a View commit details
    Browse the repository at this point in the history

  7. Refactor functions integer_decode_f32 and integer_decode_f64 with… 

    … new macro `integer_decode\!`
    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3c09565 View commit details
    Browse the repository at this point in the history

  8. Remove debug print statements

    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    32710c8 View commit details
    Browse the repository at this point in the history

  9. Rename and reorder macro parameters

    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5477176 View commit details
    Browse the repository at this point in the history

  10. Fix bug causing subnormal test case to fail

    @mtilda
    mtilda committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0a0a8e5 View commit details
    Browse the repository at this point in the history