Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial Write Not accounted for #85

Open
c-git opened this issue Jun 18, 2024 · 0 comments · May be fixed by #92
Open

Partial Write Not accounted for #85

c-git opened this issue Jun 18, 2024 · 0 comments · May be fixed by #92

Comments

@c-git
Copy link
Contributor

c-git commented Jun 18, 2024

The code doesn't handle the case that a partial write is done to lib.rs.
See line

cargo-leet/src/tool/core/helpers/write_to_disk.rs

Line 25 in 5f02af1

let _ = lib.write(format!("pub mod {module_name};").as_bytes())?;

See Clippy Lints page for why this is bad https://rust-lang.github.io/rust-clippy/master/index.html#/unused_io_amount
@c-git c-git linked a pull request Aug 25, 2024 that will close this issue
Draft
@c-git c-git linked a pull request Aug 25, 2024 that will close this issue
Allow File Overwrite #92
Draft
c-git added a commit that referenced this issue Aug 25, 2024
@c-git
fix: use write_all instead of write
b69010c 
See issue for more details
#85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow File Overwrite rust-practice/cargo-leet
1 participant
@c-git