You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
main pain point is that we do rely on ignore's logic, which currently is preventing us from implementing other sources easily... But it may be that in order to implement some include/exclude logic, we may have to modify the source trait
when we decide to add backup possibilities from other sources (opendal, rclone,..), we also need options to include/exclude which should be general and not depending on the specific backend. Currently, the includes/excludes are handled by the ignore crate which only works for local FS
adjust the tests in the same PR that we implement the new way how includes and excludes should work
ignore::LocalSource::new and tree::NodeStreamer::new_with_glob share the same logic for initializing an OverrideBuilder
we should probably refactor that to a module that contains only logic for glob handling
will also make it easier to test, I guess
this should be source-independent (or at least we should have a source-independent glob handling for include/exclude and maybe additional some source-dependent include/exclude like one-filesystem) so that we can work on other sources and fix the open issues about the ignore things
Open questions
ignore
's logic, which currently is preventing us from implementing other sources easily... But it may be that in order to implement some include/exclude logic, we may have to modify thesource
traitignore
crate which only works for local FSFeatures to add
exclude-fn
usingrhai
: Feature discussion: Programatically defined file-filtering. rustic#1317TODO
rustic
itself, to make sure, we check if the overall behaviours will stay the same or not (breaking changes): Implement more testing for including/excluding rustic#1318ignore::LocalSource::new
andtree::NodeStreamer::new_with_glob
share the same logic for initializing anOverrideBuilder
will also make it easier to test, I guess
Related
The text was updated successfully, but these errors were encountered: