Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report slice-deque as unmaintained #938

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Conversation

Moxinilian
Copy link
Contributor

A panic safety issue has been pointed out in gnzlbg/slice_deque#90 four months ago, a fix was offered in gnzlbg/slice_deque#91 three months ago but has still not been merged, the crate has last received a new commit two years ago and the maintainer seems inactive.

Tracked at gnzlbg/slice_deque#94

@Shnatsel
Copy link
Member

Last activity by the author on Github has been on Feb 21, 2021 and has been very sporadic even prior to that.

The author is the sole maintainer of cargo-asm, which I love dearly.

Could you contact the maintainer directly and ask to add a second maintainer on their projects, or https://github.com/rust-bus if they don't have anyone in mind?

@Moxinilian
Copy link
Contributor Author

I could not find any way to contact the maintainer beyond the issue I opened on the repo that has been left unanswered for 20 days.

@Shnatsel
Copy link
Member

Shnatsel commented Jul 2, 2021

Git commits include an email address, [email protected]. We should email them about slice-deque and cargo-asm, thank for their contributions so far, and ask to appoint a maintainer or add rust-bus.

@ammaraskar
Copy link
Contributor

Just checking in, did either of you end up sending out an email?

@Moxinilian
Copy link
Contributor Author

Sorry! I forgot about it. If you want to do it you can, otherwise I’ll probably do it later today. React with a thumb up if you’re doing it.

@Moxinilian
Copy link
Contributor Author

By the way, I sent the mail.

@tarcieri
Copy link
Member

Cool, let's wait a little bit to hear back

@Shnatsel
Copy link
Member

We should probably write up with a template so that we don't have to compose an email from scratch every single time.

@Moxinilian
Copy link
Contributor Author

This is a good idea. Here is what I sent:

Hello!

You appear to own a few crates on crates.io that are used a lot by the community. Thank you for your work!

One of them, slice_deque, has a security vulnerability and a PR fixing it open for a couple months now. Are you still maintaining those crates?

If you no longer can, consider giving access to those crates to a second maintainer or the
https://github.com/rust-bus !

Thanks again for the work.

@tarcieri
Copy link
Member

tarcieri commented Sep 9, 2021

@Moxinilian hear anything back yet?

@Moxinilian
Copy link
Contributor Author

Moxinilian commented Sep 9, 2021

No reply so far!

@LiquidityC
Copy link
Contributor

What are the options if we get no response? Yet another rust dep fork?

@tarcieri
Copy link
Member

tarcieri commented Oct 7, 2021

At this point I think we've waited a sufficiently long time for a reply. I'm going to go ahead and merge this.

@LiquidityC yes, at this point I'd suggest someone create a maintained fork and address the security issues.

@tarcieri tarcieri merged commit 377fdd8 into rustsec:main Oct 7, 2021
@LiquidityC
Copy link
Contributor

I created a maintained fork for slice_deque here: https://github.com/LiquidityC/slice_ring_buffer

I'm not going to be working on it but the security advisory has been patched and I can handle the occasional PR etc. Is there any way to flag this fork as an alternative to the original?

@tarcieri
Copy link
Member

You can submit a PR to this advisory adding a link to your maintained alternative:

https://github.com/rustsec/advisory-db/blob/main/crates/slice-deque/RUSTSEC-2020-0158.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants