Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on removing 'redis' as a dependency? #130

Open
golmansax opened this issue Mar 7, 2021 · 2 comments · May be fixed by #137
Open

Thoughts on removing 'redis' as a dependency? #130

golmansax opened this issue Mar 7, 2021 · 2 comments · May be fixed by #137

Comments

@golmansax
Copy link

Hi, as a follow-up to #98, what are your thoughts on removing 'redis' as a dependency?

The reason I ask is that this is the only package in our production repo that has 'redis' as a dependency.

Thanks!

@rawpixel-vincent
Copy link

makes sense, the library shouldn't require as a dependency, it could be added as an optionalDependencies in the package.json along other supported redis library if any, this need to be tested, and need to be worked out for the integration tests, so possibly also needed in the devDependencies.
PR welcomes if possible

@golmansax golmansax linked a pull request Oct 8, 2021 that will close this issue
@demsking
Copy link

redis should me moved to the peerDependencies as it's used as the main dependency by express-redis-cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants