Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements pluggable routing, based on #2790. There are still a number of open questions, and this isn't a final implementation.
TODO:
AsAny
andDynClone
Accepts
property, if possibleAsync trait
I think it's worth restricting this to be a synchronous trait. It simplifies the API, and I don't think making the trait async would enable many new options.
Implicit ranking
We can adjust the
collides
method, to output the following enum:AsAny
andDynClone
These are blanket implemented traits that solve some minor problems.
AsAny
is a polyfill for trait upcasting, enabling a trait object of typedyn UniqueProperty
to be upcast todyn Any
.DynClone
implementsClone
onBox<dyn UniqueProperty>
. TheAsAny
polyfill can be removed with some unsafe code (basically a copy-paste of stdlib'sdowncast_ref
). TheDynClone
can be removed if we useArc<dyn UniqueProperty>
, since it handles clone for us.Symmetry
Currently, we place the burden on the implementor to ensure that the property is symmetrical (i.e., iff A collides with B, then B collides with A). Since this is only checked once, we could check both sides, and warn or error if they disagree.