Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# in filenames #24

Open
minuq opened this issue Apr 6, 2022 · 2 comments
Open

# in filenames #24

minuq opened this issue Apr 6, 2022 · 2 comments

Comments

@minuq
Copy link

minuq commented Apr 6, 2022

Describe the bug
Having a file named # File.ending breaks the download link.

To Reproduce
Have a file with # in its name
Try to download it

Expected behavior
File to be downloaded

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS (but probably all)
  • Version 2.3.0, 2.4.1

Additional context
l2psync.txt

@minuq minuq mentioned this issue Apr 6, 2022
@minuq
Copy link
Author

minuq commented Apr 6, 2022

Didn't check if the downloaded file was intact (it's not), so my idea of how to fix this didn't work.

@t-schroeder
Copy link
Collaborator

Thanks for reporting this. We've put this in our backlog. We plan to change the mechanism by which Sync-my-L2P talks to Moodle. At the moment every request against Moodle goes through an extra server which might be where this bug originates. Our plan is to get rid of that server and instead talk to Moodle directly. That might already fix the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants