-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name does not fit for phpBB 4.0 & composer 2.0 #45
Comments
Yeah thanks, I'm aware of it. The problem in changing the namespace with the next release is that the policy says
I need to find a way to migrate from one extension to another smoothly. |
For this extension it wouldn't be to hard to:
But yes, this is not directly smooth :) |
The ext also adds a column |
Ah, I remember. That new column made my installation with 1.2 M posts take a while. 👼 |
For some installations it even throws SQL error sometimes as it can't alter the table to add the column. That's a common SQL problem. #42 btw right next to this issue :) |
General code cleanup and refactoring. Fixes #45.
I guess it's fixed now :) |
Will this migration run on a fresh install: https://github.com/rxu/posts_merging/blob/develop-3.2/migrations/v_3_0_0.php ? |
Yes, it should. |
Current name:
Composer 1.9.x warns with:
Deprecation warning: require.rxu/PostsMerging is invalid, it should not contain uppercase characters. Please use rxu/postsmerging instead. Make sure you fix this as Composer 2.0 will error.
phpBB is following these rules with the next major release: https://www.phpbb.com/community/viewtopic.php?f=461&t=2549901
The text was updated successfully, but these errors were encountered: