Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name does not fit for phpBB 4.0 & composer 2.0 #45

Open
Crizz0 opened this issue May 15, 2020 · 8 comments
Open

Name does not fit for phpBB 4.0 & composer 2.0 #45

Crizz0 opened this issue May 15, 2020 · 8 comments

Comments

@Crizz0
Copy link

Crizz0 commented May 15, 2020

Current name:

"name": "rxu/PostsMerging",

Composer 1.9.x warns with:
Deprecation warning: require.rxu/PostsMerging is invalid, it should not contain uppercase characters. Please use rxu/postsmerging instead. Make sure you fix this as Composer 2.0 will error.

phpBB is following these rules with the next major release: https://www.phpbb.com/community/viewtopic.php?f=461&t=2549901

@rxu
Copy link
Owner

rxu commented May 15, 2020

Yeah thanks, I'm aware of it. The problem in changing the namespace with the next release is that the policy says

It won't be possible to migrate any data from your current extension that uses Vendor/Ext to your phpBB 4.0 compatible extension.

I need to find a way to migrate from one extension to another smoothly.

@Crizz0
Copy link
Author

Crizz0 commented May 15, 2020

For this extension it wouldn't be to hard to:

  1. uninstall and delete it completely
  2. install fresh version
  3. restore the settings of this extension
    because there are only 3 options and 1 text field.

But yes, this is not directly smooth :)

@rxu
Copy link
Owner

rxu commented May 15, 2020

The ext also adds a column post_created to the posts table which has to be handled somehow.
I'm also thinking of adding own extension table for this instead.

@Crizz0
Copy link
Author

Crizz0 commented May 15, 2020

Ah, I remember. That new column made my installation with 1.2 M posts take a while. 👼

@rxu
Copy link
Owner

rxu commented May 15, 2020

For some installations it even throws SQL error sometimes as it can't alter the table to add the column. That's a common SQL problem. #42 btw right next to this issue :)
Anyway, this is the break point for changing the ext name to lowercased here. But I guess I'll do it next release anyway.

rxu added a commit that referenced this issue May 21, 2020
General code cleanup and refactoring. Fixes #45.
rxu added a commit that referenced this issue May 21, 2020
General code cleanup and refactoring. Fixes #42 and #45.
rxu added a commit that referenced this issue May 21, 2020
General code cleanup and refactoring. Fixes #42 and #45.
@rxu
Copy link
Owner

rxu commented May 21, 2020

I guess it's fixed now :)

@Crizz0
Copy link
Author

Crizz0 commented May 23, 2020

Will this migration run on a fresh install: https://github.com/rxu/posts_merging/blob/develop-3.2/migrations/v_3_0_0.php ?

@rxu
Copy link
Owner

rxu commented May 24, 2020

Yes, it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants