Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AJAX Spinner goes forever on Safari #4

Open
ryanfb opened this issue Mar 2, 2017 · 1 comment
Open

AJAX Spinner goes forever on Safari #4

ryanfb opened this issue Mar 2, 2017 · 1 comment

Comments

@ryanfb
Copy link
Owner

ryanfb commented Mar 2, 2017

See #2
@ryanfb
Copy link
Owner Author

ryanfb commented Mar 7, 2017

Looking at the console in Safari, this seems to be caused by running up against localStorage limits:

QuotaExceededError: Dom exception 22: An attempt was made to add something to storage that exceeded the quota

So we need to catch this error whenever we write to localStorage. Also, since we have to do the Fusion Tables query for the CTS text anyway, I don't think we really gain anything from memoizing the CTS result to localStorage - at least for Photios, we don't actually take advantage of this memoization.

ryanfb added a commit to dcthree/photios that referenced this issue Mar 7, 2017
@ryanfb
Don't memoize CTS text to localStorage (see ryanfb/cts-cite-driver#4)
788e5ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanfb