diff --git a/README.md b/README.md index b52a4f38c..d05c83fb4 100644 --- a/README.md +++ b/README.md @@ -69,7 +69,7 @@ nixpkgs_git_repository(name, revision, sha256) revision -

String; optional

+

String; required

Git commit hash or tag identifying the version of Nixpkgs to use.

@@ -79,14 +79,16 @@ nixpkgs_git_repository(name, revision, sha256)

String; optional

The URI of the remote Git repository. This must be a HTTP - URL. There is currently no support for authentication.

+ URL. There is currently no support for authentication. + Defaults to + upstream nixpkgs.

sha256

String; optional

-

The SHA256 used to verify the integrity of the repository

+

The SHA256 used to verify the integrity of the repository.

diff --git a/nixpkgs/nixpkgs.bzl b/nixpkgs/nixpkgs.bzl index 1814beede..218d85404 100644 --- a/nixpkgs/nixpkgs.bzl +++ b/nixpkgs/nixpkgs.bzl @@ -13,7 +13,7 @@ def _nixpkgs_git_repository_impl(ctx): nixpkgs_git_repository = repository_rule( implementation = _nixpkgs_git_repository_impl, attrs = { - "revision": attr.string(), + "revision": attr.string(mandatory = True), "remote": attr.string(default = "https://github.com/NixOS/nixpkgs"), "sha256": attr.string(), },