Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number validation shouldn’t trigger on every input change #451

Open
shawwn opened this issue Feb 1, 2025 · 0 comments
Open

Number validation shouldn’t trigger on every input change #451

shawwn opened this issue Feb 1, 2025 · 0 comments

Comments

@shawwn
Copy link
Collaborator

shawwn commented Feb 1, 2025

Describe the bug
Number revalidation causes problems in places like the Velocity dialog box. If you want to enter a negative number, it won't let you type a minus sign because as soon as you type the minus sign by itself, it validates it and it's not a valid number. You have to do a workaround by typing a digit first, then putting a minus sign in front of it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Velocity dialog box
  2. Delete the existing number
  3. Try typing a negative number
  4. The moment you type the minus sign, it validates it as not a valid number.

Expected behavior
Number validation should only trigger after a user finishes entering a new value (e.g. if they click on a different UI element so that focus leaves a number entry field, or if they press enter).

Additional context
See discord conversation in #dev from @robertnhart: https://discord.com/channels/1109381965116870667/1284714220981583947/1335205910448046150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant