From 6a6572737cb96762c946879ea0739fce2f2c6b27 Mon Sep 17 00:00:00 2001 From: Aleksandr Penskoi Date: Mon, 7 Mar 2022 20:59:16 +0300 Subject: [PATCH] Update inline TODOs. Remove some dead code. --- src/NITTA/Model/ProcessIntegrity.hs | 8 +------- test/NITTA/Model/ProcessorUnits/Broken/Tests.hs | 15 --------------- 2 files changed, 1 insertion(+), 22 deletions(-) diff --git a/src/NITTA/Model/ProcessIntegrity.hs b/src/NITTA/Model/ProcessIntegrity.hs index 64f8c13d0..bc79e62b1 100644 --- a/src/NITTA/Model/ProcessIntegrity.hs +++ b/src/NITTA/Model/ProcessIntegrity.hs @@ -53,7 +53,7 @@ checkVerticalRelations f dom codom errmsg = ) $ M.keys dom --- TODO: fix errors in process units +-- TODO: #205 Divider: missing vertical relation between Do instruction and Endpoint skipIntegrityErrors = ["instruction not related to endpoint: Instruction: Do"] collectChecks checks = case lefts checks of @@ -77,12 +77,6 @@ down2up pu = relationsMap $ mapMaybe get $ relations $ process pu get Vertical{vUp, vDown} = Just (vDown, vUp) get _ = Nothing -pid2cad pu = M.fromList $ mapMaybe get $ steps $ process pu - where - get s@Step{pID} - | Just cad <- getCad s = Just (pID, cad) - | otherwise = Nothing - pid2intermediate pu = M.fromList $ mapMaybe get $ steps $ process pu where get s@Step{pID} diff --git a/test/NITTA/Model/ProcessorUnits/Broken/Tests.hs b/test/NITTA/Model/ProcessorUnits/Broken/Tests.hs index f5a3942bb..13cf5bb6e 100644 --- a/test/NITTA/Model/ProcessorUnits/Broken/Tests.hs +++ b/test/NITTA/Model/ProcessorUnits/Broken/Tests.hs @@ -155,21 +155,6 @@ tests = , expectFail $ puCoSimTestCase "puCoSimTestCase lostEndpointInVerticalRelation" u{lostEndpointInVerticalRelation = True} [("a", 42)] [brokenBuffer "a" ["b"]] , expectFail $ puCoSimTestCase "puCoSimTestCase lostInstructionInVerticalRelation" u{lostInstructionInVerticalRelation = True} [("a", 42)] [brokenBuffer "a" ["b"]] ] - -- , testGroup - -- "broken relations integrity check negative coSim" - -- -- nittaCoSimTestCase has isLeaf and isComplete, but Relation alright because of CAD - -- -- TODO: below cases ignores lost because of CAD steps and failed because simulation - -- [ expectFail $ nittaCoSimTestCase "nittaCoSimTestCase lost Endpoints" (maBroken u{lostEndpointRelation = True}) alg - -- , expectFail $ nittaCoSimTestCase "nittaCoSimTestCase lost Instruction" (maBroken u{lostInstructionRelation = True}) alg - -- , expectFail $ typedLuaTestCase (maBroken def{lostEndpointRelation = True}) pInt "typedLuaTestCase lost Endpoints" lua - -- , expectFail $ typedLuaTestCase (maBroken def{lostInstructionRelation = True}) pInt "typedLuaTestCase lost Instruction" lua - -- ] - -- testGroup - -- "broken relations integrity check negative fails" - -- -- TODO: try lua function without break loop - -- [ expectFail $ nittaCoSimTestCase "nittaCoSimTestCase lost Function" (maBroken u{lostFunctionRelation = True}) alg - -- , expectFail $ typedLuaTestCase (maBroken def{lostFunctionRelation = True}) pInt "typedLuaTestCase lost Function" lua - -- ] ] where u = def :: Broken T.Text Int Int