Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CADStep + RefactorStep to IntegretyCheck of ProcessUnits #207

Open
ryukzak opened this issue Mar 7, 2022 · 0 comments
Open

Add CADStep + RefactorStep to IntegretyCheck of ProcessUnits #207

ryukzak opened this issue Mar 7, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hs Haskell test Improve test quality

Comments

@ryukzak
Copy link
Owner

ryukzak commented Mar 7, 2022

Currently, we check relations:

[ checkVerticalRelations (up2down pu) (pid2intermediate pu) (pid2endpoint pu) "intermediate not related to endpoint"
, checkVerticalRelations (down2up pu) (pid2endpoint pu) (pid2intermediate pu) "endpoint not related to intermediate"
, checkVerticalRelations (up2down pu) (pid2endpoint pu) (pid2instruction pu) "endpoint not related to instruction"
, checkVerticalRelations (down2up pu) (pid2instruction pu) (pid2endpoint pu) "instruction not related to endpoint"

But also we need to check vertical relations between CADStep + RefactorStep and Intermediate level. For that we need:

  • In NITTA.Model.ProcessIntegrity:
    • pid2cad
    • refactor2cad
    • new calls of checkVerticalRelations
  • Modify BrokenPU and check that our test works.
  • Fix all issues in processor units.
pid2cad pu = M.fromList $ mapMaybe get $ steps $ process pu
    where
        get s@Step{pID}
            | Just cad <- getCad s = Just (pID, cad)
            | otherwise = Nothing
@ryukzak ryukzak added enhancement New feature or request good first issue Good for newcomers hs Haskell test Improve test quality labels Mar 7, 2022
@ryukzak ryukzak changed the title Add CAD steps and refactoring to IntegretyCheck of ProcessUnits Add CADStep + RefactorStep to IntegretyCheck of ProcessUnits Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hs Haskell test Improve test quality
Projects
None yet
Development

No branches or pull requests

1 participant