Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint nine #30

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sprint nine #30

wants to merge 3 commits into from

Conversation

axpart
Copy link
Contributor

@axpart axpart commented Oct 20, 2020

Typeahead search box implementation complete for fetching twitter screen names

@s2t2
Copy link
Owner

s2t2 commented Oct 20, 2020

Very cool, thanks @axpart. Here are some comments:

  • We want a clean PR to only include typeahead related stuff (not the sticky nav stuff), so could you checkout the master branch, then fetch from my repo to update your master branch, and then checkout a new feature branch called something like "typeahead" and just do the type-ahead work there?
  • Let's import the existing data without making a copy of it or modifying it. If you need to map it to use just a list of screen names, that's fine.
  • For integrating the typeahead with the existing text input, based on a quick review of the package documentation, let's try hooking into the renderSuggestion method, passing the existing form control element instead of a naked span element.
  • We don't need highlighting (at least in the first iteration)

@axpart
Copy link
Contributor Author

axpart commented Oct 21, 2020

  • I have checked out from the master branch and fetched to a new branch called typeahead.

@s2t2
Copy link
Owner

s2t2 commented Oct 21, 2020

Ok cool. By the way, if that package is giving you issues, we might alternatively try this package:

https://ericgio.github.io/react-bootstrap-typeahead/

https://github.com/ericgio/react-bootstrap-typeahead/blob/master/docs/Usage.md

https://ericgio.github.io/react-bootstrap-typeahead/

I like that typing "c" will match "Massachusetts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants