-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to stop/pause/resume an workflow #88
Comments
does also we need to pause workflow or only stop? |
Pause would be good to have. Implementing pause will need some changes in executor. Stop will be a implicit feature of the sdk. It can use the statestore to mark a pipeline as inactive. If a node is already started execution of its operations then it will be hard to stop, but afterwards the execution will be stopped. pause may need to be handled by the executor. Currently we forward the intermediate state to next execution via http request. While it pause the intermediate state needs to be stored somewhere so that it can be replayed. While executing a branches all intermediate request need to be stored. We can use state store for it. Again it would be hard to pause an active Node execution but next nodes can be paused |
How can i serialize current workflow to store? Does it already have some sort of ability to export it to some representation? |
Check https://godoc.org/github.com/s8sg/faas-flow/sdk/exporter These provide functionality to export the workflow definition in JSON |
Thanks! really helpful. How can i after that import flow by this json representation? |
as i see now is only way it to unmarshal json to https://godoc.org/github.com/s8sg/faas-flow/sdk#DagExporter after that iterate over nodes and construct DAG. Do you have some different way of restoring workflow from json? |
Now I see whats your point, no thats the only way for now. |
no problem, i'm iterate on unmarshaled struct... |
If you come up with the code to construct flow with iteration can you raise a PR adding it in the `sdk. The similar can be used for AWS State language |
Yes, I'm plan to do that.
ср, 21 авг. 2019 г., 11:03 Swarvanu Sengupta <[email protected]>:
… If you come up with the code to construct flow with iteration can you
raise a PR adding it in the `sdk. The similar can be used for AWS State
language
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#88?email_source=notifications&email_token=AADVQGY7HVHLZNRUGOYS65DQFTZG3A5CNFSM4IJTCZ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4YZ3XA#issuecomment-523345372>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADVQG7CTFDTCTZVPU5PVYTQFTZG3ANCNFSM4IJTCZ5Q>
.
|
As suggested in issue-#81 by @kwojcicki
We will provide ability to stop a workflow
The text was updated successfully, but these errors were encountered: