Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serendipity Composer Update | Uniify plugins in core and additional_plugins #821

Open
surrim opened this issue Feb 14, 2024 · 5 comments
Open

Comments

@surrim
Copy link
Contributor

surrim commented Feb 14, 2024

There are four plugins which exists in Serendipity and additional_plugins:

Plugin name S9Y AP
serendipity_event_gravatar 1.63.1 1.62.3
serendipity_event_multilingual 2.36.2 2.35.1
serendipity_plugin_authors 2.2 2.2
serendipity_plugin_quicksearch 1.2 1.2

There should be only one source. Everything which is optional should be in additional_plugins.

@stevleibelt
Copy link

Just for the four eyes principle, @surrim is right. All mentioned plugins are available in additional_plugins and plugins.

@garvinhicking
Copy link
Member

I believe the reasoning at some point was to "bundle" important plugins with our core release. The better way would've been to do this via on-release bundling - which we weren't able to do "back in the days". Also I think we did some things with the plugins that affected their core compatibility, but I'm not sure of this.

A problem is that when we now move plugins outside of the core, they'll not get deleted when people update.

So maybe the best course of action is to "just" synchronize the affected plugins?

The ideal way of course would be to make plugins be composer packages, migrate the core to use composer for plugins too, and then create a proper release architecture.... I did some initial work for a composer move (see the git branch), but I can't do it alone and need some motivation (&time). 🥹

@stevleibelt
Copy link

@garvinhicking Is there a list or "howto"-Section you can point volunteers to support you on the composer task?

@garvinhicking
Copy link
Member

@stevleibelt That would be terriffic, and might get me involved somehow. It's just so much that I'm seeing a steep hill I'd have to climb alone. Serendipity has a very small userbase and I'm just not sure there is "public demand" for that. But the task at hand would be a cool one, and we'd all learn a lot from it. So... if there are volunteers (LIKE YOU? :-)) then please do get in touch.

I'm still on the s9y.slack.com, but the more transparently public we can communicate this, the better.

I've just updated https://github.com/s9y/Serendipity/blob/feature/composer/README.markdown#concept again to add some thoughts...

( @onli )

@onli
Copy link
Member

onli commented Feb 19, 2024

@garvinhicking Just to make sure you have seen it, @mmitch also volunteered to help at https://www.onli-blogging.de/2323/comments.html#c10436

@garvinhicking garvinhicking changed the title Duplicate plugins in Serendipity/additional_plugins Serendipity Composer Update | Uniify plugins in core and additional_plugins Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants