Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to close the GitHub react card #16

Open
mbaralle opened this issue Feb 19, 2020 · 2 comments
Open

I want to close the GitHub react card #16

mbaralle opened this issue Feb 19, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mbaralle
Copy link

How to reproduce

  1. Open an article
  2. Go to the bottom and move the mouse over the reaction emojis
    image
  3. Click on the blue smiley on the right to open the GitHub react card

Expected

Able to close the card

Actual

No way to close the card

Hint

  • That could be solved with an event on a button and/or Esc key
  • Another solution is to close when the mouse leaves the react card or when a touch event is triggered outside of the react card (which implies that the react card is positioned under the mouse/touch point)
@jvnm-dev
Copy link
Collaborator

jvnm-dev commented Feb 19, 2020

Hi, actually you can close it by clicking on the blue smiley again.

... when a touch event is triggered outside of the react card ...

Indeed, this could improve the UX

@saadpasta
Copy link
Owner

@mbaralle you could close the popup by clicking the emoji reaction but you can improve the UX by closing the popup when user clicked outside the popup

@jvnm-dev jvnm-dev added enhancement New feature or request good first issue Good for newcomers labels Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants