Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_cli_owners_from_file / add support for encrypted keystore-files #435

Open
ratio91 opened this issue Jul 12, 2024 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@ratio91
Copy link

ratio91 commented Jul 12, 2024

Copy-pasting seed phrases or private keys is highly insecure. Ledger and Trezor support is great, but also cumbersome.
Ideally, encrypted keystore files could be supported where the passphrase would either needs to be entered interactively or via a secret.
Docker swarm mode supports docker secrets, which allows accessing them under /run/secrets/<secret_name>.

@ratio91 ratio91 added the enhancement New feature or request label Jul 12, 2024
@Uxio0
Copy link
Member

Uxio0 commented Jul 12, 2024

Sounds like a good idea. Could you elaborate more about how would you like to use docker secrets?

@ratio91
Copy link
Author

ratio91 commented Jul 12, 2024

I would create a docker secret first (e.g. a keystorefile file or secret) using:
cat myKeyStoreFile.json | docker secret create signer1 -

Then I would load the secret which never get's persisted on the file system btw but are only stored in memory as data rafts. They only exist in a virtual filesystem managed by Docker, and they are only accessible to the containers that have been granted access to them.
load_cli_owners_from_file /run/secrets/signer1

@Uxio0
Copy link
Member

Uxio0 commented Jul 12, 2024

Thanks for the explanation. We will add it to our roadmap, but if you want you can send a PR in the meantime and we will kindly review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants