Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowance Module Does not Support Non-Reverting ERC-20 Transfers #237

Open
nlordell opened this issue Jan 26, 2024 · 0 comments
Open

Allowance Module Does not Support Non-Reverting ERC-20 Transfers #237

nlordell opened this issue Jan 26, 2024 · 0 comments

Comments

@nlordell
Copy link
Collaborator

Description

The allowance module will not revert when transfer-ing a token that returns false instead of reverting on failed a transfer. This means that for some tokens, the module won't correctly revert with Could not execute token transfer on failed transfers.

Expected Behaviour

Transferring a token where transfer returns false but does not revert should cause the allowance module to revert as well. Additionally, calling transfer on an address without code should potentially revert as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant