Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain: switch network doesn't work in wallet connect flow if the user is trying to connect on unsupported network #4670

Open
liliya-soroka opened this issue Dec 16, 2024 · 2 comments · May be fixed by #4742
Assignees
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@liliya-soroka
Copy link
Member

Bug description

Multichain: switch network doesn't work in walletconnection if the user is trying to connect on unsupported network

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet/ any

Steps to reproduce

  1. Go to the safe on Sepolia
  2. try to connect opensea
    Current result: connect dialog with supported network and option to switch network appears, but it's not possible to use switch network

Expected result

Make sure that the user can switch to the right network in the WC dialog

Obtained result

Screenshots

image
@liliya-soroka liliya-soroka added bug Something isn't working major Major bug (to be solved in the next release) labels Dec 16, 2024
@liliya-soroka liliya-soroka changed the title Multichain: switch network doesn't work in walletconnection if the user is trying to connect on unsupported network Multichain: switch network doesn't work in wallet connect flow if the user is trying to connect on unsupported network Dec 16, 2024
@the-real-chrizzo
Copy link

Short-term fix:

  • Adjust "Switch network" --> "Switch Safe Account".
  • If there is no Safe Account to switch to --> hide
    Long-term to be discussed.

@katspaugh katspaugh assigned katspaugh and unassigned schmanu Jan 6, 2025
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Jan 6, 2025
@katspaugh katspaugh moved this from New issues to In Progress in Safe{Wallet} Jan 6, 2025
@katspaugh
Copy link
Member

We decided to remove the network selector from that component entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Status: Ready for QA
Development

Successfully merging a pull request may close this issue.

5 participants
@liliya-soroka @katspaugh @schmanu @the-real-chrizzo and others