Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank metric channel #32330

Open
mbombar opened this issue Aug 3, 2021 · 17 comments
Open

Rank metric channel #32330

mbombar opened this issue Aug 3, 2021 · 17 comments

Comments

@mbombar
Copy link

mbombar commented Aug 3, 2021

In coding theory, the most common metric is the Hamming metric. However, codes in the rank metric have been introduced in Sage 9.1 last year, and have gained a large interest for their use in network coding, and in cryptography for instance.

This ticket implements the rank metric analogue of the channels.StaticErrorRateChannel, i.e. a channel which creates an error of specific rank in each transmitted message.

Component: coding theory

Keywords: Rank-metric, Channel

Author: Maxime Bombar

Branch/Commit: u/gh-mbombar/rank_metric_channel @ fc12ce0

Issue created by migration from https://trac.sagemath.org/ticket/32330

@mbombar mbombar added this to the sage-9.4 milestone Aug 3, 2021
@mbombar
Copy link
Author

mbombar commented Aug 3, 2021

Branch: u/gh-mbombar/rank_metric_channel

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 3, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

abf97b8[sage/coding] Add new channel: Rank metric static error channel

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 3, 2021

Commit: abf97b8

@mbombar
Copy link
Author

mbombar commented Aug 3, 2021

Author: Maxime Bombar

@mbombar
Copy link
Author

mbombar commented Aug 3, 2021

Changed keywords from none to Rank-metric, Channel

@mbombar

This comment has been minimized.

@mbombar
Copy link
Author

mbombar commented Aug 3, 2021

comment:4

Since Sage development has entered the release candidate phase for 9.4, I guess the milestone for this ticket should be set to 9.5.

@mbombar mbombar modified the milestones: sage-9.4, sage-9.5 Aug 3, 2021
@mbombar

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 4, 2021

Changed commit from abf97b8 to d7b6180

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d7b6180[coding/channel] Patchbot compliance (blocks plugin). Also edit older code.

@fchapoton
Copy link
Contributor

comment:7

Lorsque les erreurs du patchbot sont clairement pas liées au ticket, on peut les oublier.

Le plugin "blocks" du patchbot n'est pas disponible ailleurs que dans le patchbot. A mon avis, ca ne justifie pas de se lancer dans l'elevage personnel d'un patchbot. Meme si ce n'est pas si compliqué.

Une typo : people comming from the Hamming world

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

eb704e8[sage/coding/channel] Fix typos
fc12ce0[sage/coding/channel] Add AUTHORS block

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2021

Changed commit from d7b6180 to fc12ce0

@mbombar
Copy link
Author

mbombar commented Aug 6, 2021

comment:9

(I continue in English for more readability)

Replying to @fchapoton:

Lorsque les erreurs du patchbot sont clairement pas liées au ticket, on peut les oublier.

Ok.

Le plugin "blocks" du patchbot n'est pas disponible ailleurs que dans le patchbot. A mon avis, ca ne justifie pas de se lancer dans l'elevage personnel d'un patchbot. Meme si ce n'est pas si compliqué.

Ok.

Une typo : people comming from the Hamming world

Ah thanks. I fixed it. (I also found another typo).

Then, I think it should be ready for review now.

@fchapoton
Copy link
Contributor

comment:10

Cette ligne me semble inutile:

+        w = copy(message)

@fchapoton
Copy link
Contributor

comment:11

La branche rouge signale un conflit avec la dernière version => needs-work

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022
@mkoeppe mkoeppe removed this from the sage-9.7 milestone Sep 19, 2022
@mkoeppe mkoeppe added this to the sage-9.8 milestone Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@jlavauzelle
Copy link
Contributor

I merged this branch and made a pull request here: #39117. A few minor fixes and updates have also been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants