Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/update-meson.py is too undiscoverable #39172

Open
user202729 opened this issue Dec 19, 2024 · 0 comments
Open

tools/update-meson.py is too undiscoverable #39172

user202729 opened this issue Dec 19, 2024 · 0 comments

Comments

@user202729
Copy link
Contributor

user202729 commented Dec 19, 2024

Problem Description

As in the title. It leads to unnecessarily too many confusion ( #39159 #39046 (comment) )

Proposed Solution

I suggest the following

  • the meson GitHub CI action automatically runs the script before building, then gives a failure if git diff returns nonzero diff (but proceed with the build and test anyway to save time)
  • pre-commit hook?
  • at the head of each meson.build file, say "this file is autogenerated" etc. (or only "mostly autogenerated"? I don't know)

Maybe @tobiasdiez is the best one to do this. (I'm not entirely sure how to use the script either (just run it?), or is it supposed to be fully automatic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant