Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unparsable API responses should raise UnavailableError #56

Open
mtowers opened this issue Aug 28, 2014 · 1 comment
Open

Unparsable API responses should raise UnavailableError #56

mtowers opened this issue Aug 28, 2014 · 1 comment

Comments

@mtowers
Copy link

mtowers commented Aug 28, 2014

When the API returns a response that is not valid JSON, the service should be presumed to be unavailable.

Only when valid JSON is returned that represents a server-side error should api_request return a ruby hash with a valid SailThru error code assigned.

See related pull request.

@lindsaycooper
Copy link
Contributor

@mtowers This change is not backwards compatible. We will consider making this change in a major version upgrade but for now we are going to keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants