Add a test for enabling hdr color mode

saket · Dec 7, 2024 · 0575f7f · 0575f7f
1 parent 5043a65
commit 0575f7f
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 1 deletion.
diff --git a/zoomable-image/sub-sampling-image/src/androidTest/assets/vadapav_ultra_hdr.jpg b/zoomable-image/sub-sampling-image/src/androidTest/assets/vadapav_ultra_hdr.jpg
diff --git a/...pling-image/src/androidTest/kotlin/me/saket/telephoto/subsampling/SubSamplingImageTest.kt b/...pling-image/src/androidTest/kotlin/me/saket/telephoto/subsampling/SubSamplingImageTest.kt
@@ -3,6 +3,7 @@
 package me.saket.telephoto.subsampling
 
 import android.content.Context
+import android.content.pm.ActivityInfo
 import android.graphics.BitmapFactory
 import android.net.Uri
 import androidx.compose.foundation.border
@@ -817,6 +818,43 @@ class SubSamplingImageTest {
     }
   }
 
+  @Test fun enable_hdr_color_mode_for_images_that_contain_ultra_hdr_content() {
+    assertThat(rule.activity.window.colorMode).isEqualTo(ActivityInfo.COLOR_MODE_DEFAULT)
+
+    var imageAssetName by mutableStateOf("fox_1000.jpg")
+    rule.setContent {
+      val zoomableState = rememberZoomableState()
+      SubSamplingImage(
+        modifier = Modifier
+          .fillMaxSize()
+          .zoomable(zoomableState)
+          .testTag("image"),
+        state = rememberSubSamplingImageState(
+          zoomableState = zoomableState,
+          imageSource = SubSamplingImageSource.asset(imageAssetName),
+        ),
+        contentDescription = null,
+      )
+    }
+
+    rule.waitUntil {
+      rule.onNodeWithTag("image").isImageDisplayed()
+    }
+    assertThat(rule.activity.window.colorMode).isEqualTo(ActivityInfo.COLOR_MODE_DEFAULT)
+
+    imageAssetName = "vadapav_ultra_hdr.jpg"
+    rule.waitUntil {
+      rule.onNodeWithTag("image").isImageDisplayedInFullQuality()
+    }
+    assertThat(rule.activity.window.colorMode).isEqualTo(ActivityInfo.COLOR_MODE_HDR)
+
+    imageAssetName = "path.jpg"
+    rule.waitUntil {
+      rule.onNodeWithTag("image").isImageDisplayedInFullQuality()
+    }
+    assertThat(rule.activity.window.colorMode).isEqualTo(ActivityInfo.COLOR_MODE_DEFAULT)
+  }
+
   @Suppress("unused")
   enum class LayoutSizeParam(val modifier: Modifier) {
     FillMaxSize(Modifier.fillMaxSize()),

diff --git a/...src/main/kotlin/me/saket/telephoto/subsamplingimage/internal/AndroidImageRegionDecoder.kt b/...src/main/kotlin/me/saket/telephoto/subsamplingimage/internal/AndroidImageRegionDecoder.kt
@@ -34,7 +34,7 @@ internal class AndroidImageRegionDecoder private constructor(
     val options = BitmapFactory.Options().apply {
       inSampleSize = region.sampleSize.size
       inPreferredConfig = imageOptions.config.toAndroidConfig()
-      if (Build.VERSION.SDK_INT >= 26) {
+      if (SDK_INT >= 26) {
         inPreferredColorSpace = imageOptions.androidColorSpace
       }
     }