Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'external' icon for external links #194

Open
tiiavalt opened this issue Apr 30, 2021 · 0 comments · Fixed by #197
Open

Add 'external' icon for external links #194

tiiavalt opened this issue Apr 30, 2021 · 0 comments · Fixed by #197
Assignees
Labels
enhancement New feature or request

Comments

@tiiavalt
Copy link
Contributor

tiiavalt commented Apr 30, 2021

Is your feature request related to a problem? Please describe.
Currently there's no way of knowing whether link is internal or external until user clicks it.

Describe the solution you'd like
Let's add an external icon to each external link to indicate that it will take user outside of Epi.

--
The result

  • Created a new component (ExternalLink) that has the external icon right after link's label. It also has aria-label "external link), so external links can be identified by the screen readers as well.
  • Extra improvement: added default font for css font-family rule to fix warnings.
@tiiavalt tiiavalt added the enhancement New feature or request label Apr 30, 2021
@tiiavalt tiiavalt self-assigned this Apr 30, 2021
@tiiavalt tiiavalt changed the title Add external icon for external links Add 'external' icon for external links Apr 30, 2021
@tiiavalt tiiavalt linked a pull request May 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant