Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Capture status and wait timeout #19

Open
jlecuyer opened this issue Mar 24, 2023 · 2 comments
Open

[Feature request] Capture status and wait timeout #19

jlecuyer opened this issue Mar 24, 2023 · 2 comments

Comments

@jlecuyer
Copy link

The requests

  1. Add a facultative max_wait_seconds argument to the wait() function to set a max wait time, after which the capture would be stopped
  2. Add a method to query for the capture status (is it still running or has it completed)

The context

I want to use the logic2-automation in a regression testing rack running a github self-hosted runner
In case of firmware bug, the trigger for which the capture is waiting may never occur.

My Current approach

My current approach is to

  1. Setup the capture as timed capture
  2. Trigger the event I am capturing for
  3. Sleep for the max wait time of the event
  4. Call the wait method to forcefully stop the capture.
  5. Parse the csv to see if the trigger occurred
  6. Clean-up the analog capture to remove entry before the trigger

Although my current approach is operational, a max wait time would

  • Accelerate the result acquisition when the trigger occurred before timeout
  • Remove the need for extra processing to get the analog reading starting at trigger

Thanks you and nice job !

Jonathan

@Marcus10110
Copy link
Contributor

Thanks Jonathan, the existing API missed this situation.

We're tracking the request here, and I've added a possible workaround there too, although it doesn't solve this completely either: https://ideas.saleae.com/b/feature-requests/automation-api-set-a-timeout-when-looking-for-trigger/

We'll definitely want to add this in the future.

@jlecuyer
Copy link
Author

Thanks @Marcus10110 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants