Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): associate label with button #725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewvasilchuk
Copy link
Contributor

In Base Combobox example <label> is associated with non-existed <input> element. The value of for attribute is the id of the <input> element, which is not rendered in DOM. Instead a <button> element is rendered.

The proposed change is to associate label with a button, instead of associating it with a non-existing input element.

@greensteph
Copy link
Contributor

Hello, thanks so much for your contribution. I've created an internal ticket to shepard this through our workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants