fix(rtl): change ltr text-align to rtl-compatible form #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @maxpowa to sign the Salesforce Inc. Contributor License Agreement. |
|
Not sure whats up with the @salesforce-cla bot, I've signed the CLA and it hasn't updated... Edit: Oopsie, used the wrong author email 😭 |
maxpowa
force-pushed
the
fix-rtl-core-pollution
branch
from
3329cae
to
ba2e438
Compare
|
Hi @maxpowa Thank you for your contribution! With these changes affect the CSS, please allow us some time to internally run visual regression testing. I've created an internal ticket to shepherd this through our workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
text-align: lefttotext-align: startto increase RTL compatibility.Acceptance Criteria
General