Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make major version match Sal version #2

Open
grahamgilbert opened this issue Apr 10, 2018 · 5 comments
Open

Make major version match Sal version #2

grahamgilbert opened this issue Apr 10, 2018 · 5 comments

Comments

@grahamgilbert
Copy link
Member

For the SAML variant, the version matches the Sal version, appending an additional subversion to the end if more frequent releases are made.

@haribert
Copy link
Collaborator

This makes sense! If I see how often you release, a subversion should not be necessary. It could be, that the authentication features may change between different Sal versions.
Just changed it. Can you please check if it is in agreement with your thought?

@haribert
Copy link
Collaborator

@grahamgilbert Is it possible, that you add this repository/Dockerfile to the dockerhub of macadmins?

@haribert
Copy link
Collaborator

haribert commented Nov 1, 2018

@grahamgilbert Can you please add this repository/Dockerfile to the dockerhub of macadmins?

@grahamgilbert
Copy link
Member Author

Yes, what’s your username on there?

@haribert
Copy link
Collaborator

haribert commented Nov 8, 2018

My colleague @aschwanb will take care of the Docker images. You can use his account aschwanb in Dockerhub. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants