feat(map): update to v5 map.jinja #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baby-gnu
force-pushed
the
feature/v5-map.jinja
branch
from
2767ddc to
ca16223
Compare
|
I made the PR to investigate the issue. This formula need to setup things before executing the real
This means that we should solve saltstack-formulas/apache-formula#295, i.e. explicitely do |
baby-gnu
force-pushed
the
feature/v5-map.jinja
branch
from
ca16223 to
235e329
Compare
baby-gnu
force-pushed
the
feature/v5-map.jinja
branch
from
235e329 to
3b64dbd
Compare
baby-gnu
force-pushed
the
feature/v5-map.jinja
branch
from
3b64dbd to
1183727
Compare
The `cert-formula` requires a dedicated `map.jinja` configuration to skip values from `salt["config.get"](cert)` for compatibility. BREAKING CHANGE: `map.jinja` now export a generic `mapdata` variable BREAKING CHANGE: the parameters per grains are now under `cert/parameters/`
The setup of certificates to remove during the test need to use `map.jinja` but it fails to load the YAML files since the `tplroot` is not the `cert` formula directory in this case. We need to enable the import of `mapdata` from outside the `cert-formula` since `tplroot` can't be set correctly when the import: - is done from another top directory than the `cert` - the import is done `with context` In this case, the `tpldir` is set to the directory of the importer `.sls` file instead of the `.jinja` imported one. We force the `without context` which permits to directly use `tpldir` as the `tplroot` which is the directory of the imported file. BREAKING CHANGE: `map.jinja` import must use `without context` BREAKING CHANGE: `libmapstack.jinja` import must use `without context` BREAKING CHANGE: `libmatchers.jinja` import must use `without context`
We need to update the reference files to include the `map.jinja` sources configuration.
baby-gnu
force-pushed
the
feature/v5-map.jinja
branch
from
1183727 to
4041422
Compare
myii
approved these changes
Apr 13, 2021
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?Yes.
BREAKING CHANGE:
map.jinjanow export a genericmapdatavariableBREAKING CHANGE: the parameters per grains are now under
cert/parameters/Related issues and/or pull requests
saltstack-formulas/template-formula#225
Describe the changes you're proposing
feature(map): update to generic v5
map.jinjaThe
cert-formularequires a dedicatedmap.jinjaconfiguration to skip values fromsalt["config.get"](cert)for compatibility.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context