[BUG] Relative includes cannot be used for sls requisites

[myii]

Your setup

Formula commit hash / release tag

Latest: f4cdc94.

Versions reports (master & minion)

(Travis).

Pillar / config used

https://github.com/saltstack-formulas/packages-formula/blob/7495961d5219306e8d3d5e021acc9e9230eb6eba/test/salt/pillar/ubuntu.sls#L4-L9

# Dependency (golang)
golang:
  pkg:
    name: golang
    use_upstream_repo: false
    use_upstream_archive: false

---

Bug details

Describe the bug

https://travis-ci.org/github/myii/packages-formula/jobs/694412318#L4276-L4282

                 ID: golang-package-install-pkg-installed
           Function: pkg.installed
               Name: golang
             Result: False
            Comment: The following requisites were not found:
                                 require:
                                     sls: .repo

Steps to reproduce the bug

(Travis run for the packages-formula).

Expected behaviour

No error.

Attempts to fix the bug

@noelmcloughlin This is based on an upstream bug in Salt as discussed here: saltstack-formulas/template-formula#48 (comment).

It's a shame that relative includes (i.e. .install) can't be used when settings a requisite based on an sls -- this is an upstream bug that still hasn't been resolved.

This is the offending line that needs to be fixed:

golang-formula/golang/package/install.sls

Line 5 in f4cdc94

{%- set sls_repo_install = '.repo' %}

The solution is the same as is used in the template-formula, i.e. probably:

{%- set sls_repo_install = tplroot ~ '.package.repo.install' %}

Furthermore, there really needs to be a test suite for package-based installations -- all are archive-based at the moment.

Additional context

[myii]

@noelmcloughlin Actually, there's an additional problem here, use_upstream_repo: false is no longer respected, i.e.:

golang:
  pkg:
    use_upstream_repo: false

It was removed here in a recent commit: 8a9b380#diff-e697bcf6a8534d9757121c1934dd6148L8.

[myii]

In attempting to fix this, also hitting another bug which seems to be introduced recently:

       local:
           Data failed to compile:
       ----------
           Rendering SLS 'base:golang.config.environ' failed: Jinja variable 'dict object' has no attribute 'path'

Only available if golang.pkg.use_upstream_archive?

golang-formula/golang/map.jinja

Line 66 in e926a71

{%- do golang.update({'path': golang.pkg.archive.name}) %}

---

UPDATE: Workaround is to set golang.path: '' in defaults.yaml.

[myii]

Even with the correct sls reference, I've hit the following error:

                 ID: golang-package-install-pkg-installed
           Function: pkg.installed
               Name: golang
             Result: False
            Comment: The following requisites were not found:
                                 require:
                                     sls: golang.package.repo.install

Because golang.package.repo.install is empty when golang.pkg.use_upstream_repo: false. I've resolved it locally by moving the Jinja if back into golang/package/install.sls -- in both places, unfortunately.

[myii]

I've got a fix in place for this, all states passing, just the tests for opensuse and arch need a tiny adjustment:

• https://travis-ci.org/github/myii/golang-formula/builds/694764549

[myii]

Fixed:

• https://travis-ci.org/github/myii/golang-formula/builds/694779825

[saltstack-formulas-travis]

🎉 This issue has been resolved in version 0.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀