Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debian] [stretch] loosing default ssl settings #181

Open
arthurzenika opened this issue Jan 3, 2018 · 2 comments
Open

[debian] [stretch] loosing default ssl settings #181

arthurzenika opened this issue Jan 3, 2018 · 2 comments

Comments

@arthurzenika
Copy link
Contributor

When deploying nginx formula to debian stretch with no pillars, it removes ssl_protocols and ssl_prefer_server_ciphers

                  -	##
                  -	# SSL Settings
                  -	##
                  -
                  -	ssl_protocols TLSv1 TLSv1.1 TLSv1.2; # Dropping SSLv3, ref: POODLE
                  -	ssl_prefer_server_ciphers on;

Would you agree to a PR that adds these settings ?

@noelmcloughlin
Copy link
Member

noelmcloughlin commented Jan 25, 2019

Hi @arthurlogilab
It is good that TLS v1 and 1.1 are removed. But you can raise PR to set TLSv1.2 as default?
And yes, I think ssl_prefer_server_ciphers: 'on' is acceptable formula default.

ref:
http://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl_prefer_server_ciphers
https://github.com/ssllabs/research/wiki/SSL-and-TLS-Deployment-Best-Practices#23-use-secure-cipher-suites

@noelmcloughlin
Copy link
Member

On second thoughts - It might not be optimal for security but these no-pillar settings are correct default nginx settings after installation.

I don't see these documented in pillar.example - Could you raise PR on that plese.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants