Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Service is not reloaded when snippets are added #291

Open
sticky-note opened this issue Mar 8, 2022 · 0 comments
Open

[BUG] Service is not reloaded when snippets are added #291

sticky-note opened this issue Mar 8, 2022 · 0 comments
Assignees
Labels

Comments

@sticky-note
Copy link
Member

sticky-note commented Mar 8, 2022

Your setup

Formula commit hash / release tag

nginx-formula v2.6.0

Versions reports (master & minion)

Both master and minon: salt version 3003

Pillar / config used

My nginx.conf is like:

...
http {
  ...
  include snippets/*.cnf
  ...
}

Add this snippet on a second state.highstate run

nginx:
  snippets:
+    global.cnf:
+      - underscore_in_header: 'on'

Bug details

Describe the bug

  • Run a highstate with nginx-formula included
    First run is ok, nginx is started with nginx.conf above

  • Add snippet above
    Run a second state.highstate
    Nginx service do not get reloaded on the second run
    Changes are not taken iinto account.

minion.org.com:
          ID: nginx_snippet_global.cnf
    Function: file.managed
        Name: /usr/local/etc/nginx/snippets/global.cnf
      Result: True
     Comment: File /usr/local/etc/nginx/snippets/global.cnf updated
     Started: 18:52:03.020966
    Duration: 1665.896 ms
     Changes:   
              ----------
              diff:
                  New file
              mode:
                  0644

Summary for minion.org.com
--------------
Succeeded: 143 (changed=1)
Failed:      0
--------------
Total states run:     143
Total run time:    57.696 s

Steps to reproduce the bug

state.apply nginx two times with a new snippet the second time.

Expected behaviour

Reload of nginx service when we add new snippets

Attempts to fix the bug

Additional context

@sticky-note sticky-note added the bug label Mar 8, 2022
@sticky-note sticky-note changed the title [BUG] Service is nor reloaded when snippets are added [BUG] Service is not reloaded when snippets are added Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants