-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkgrepo): impl new logic after migration to packages.broadcom.com
#566
Conversation
69457f0
to
9ccc8fa
Compare
6644909
to
b83c431
Compare
@sticky-note Thank you for taking the time to put this together. I was able to give it a quick look at it now and noticed a few small things around the CI pipeline. I added a suggestion above to fix the pre-commit job The commit lint jobs are failing because the commit message is 6 characters longer than expected. Could you please amend the commit message to the expected length since this is parsed for the changelog.
https://github.com/saltstack-formulas/salt-formula/actions/runs/11830833414/job/32965007118?pr=566 I plan to take a closer look at this soon. |
b25c12d
to
56a10e7
Compare
packages.broadcom.com
packages.broadcom.com
Done. Sorry for that. I am actually Testing for Debian 12, Ubuntu 24.04, AlmaLinux 9, rocky 9 Do I need to do something for SLES, OpenSUSE or the binaries are managed by them ? |
346a997
to
5535039
Compare
5535039
to
d458302
Compare
Looking at the CI jobs it appears that https://gitlab.com/saltstack-formulas/salt-formula/-/jobs/8376038655 |
d458302
to
d79c22d
Compare
@jeff350 @sir-ragna I confirm It is working on Ubuntu 22.04, Debian 12, Almalinux 9 with salt Don't know how to test with SUSE, OpenSUSE |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No. The Formula was broken since the migration after all.
Related issues and/or pull requests
Resolves: #565
Obsoletes: #561
Maybe can closes: #545
Describe the changes you're proposing
Update logic following the migration to
packages.broadcom.com
. For further info, see:-> https://saltproject.io/blog/upcoming-salt-project-docs-and-repo-migration/
-> https://docs.saltproject.io/salt/install-guide/en/latest/
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context