Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkgrepo): impl new logic after migration to packages.broadcom.com #566

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sticky-note
Copy link
Member

@sticky-note sticky-note commented Nov 14, 2024

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No. The Formula was broken since the migration after all.

Related issues and/or pull requests

Resolves: #565
Obsoletes: #561
Maybe can closes: #545

Describe the changes you're proposing

Update logic following the migration to packages.broadcom.com. For further info, see:
-> https://saltproject.io/blog/upcoming-salt-project-docs-and-repo-migration/
-> https://docs.saltproject.io/salt/install-guide/en/latest/

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

pillar.example Outdated Show resolved Hide resolved
@jeff350
Copy link

jeff350 commented Nov 14, 2024

@sticky-note Thank you for taking the time to put this together. I was able to give it a quick look at it now and noticed a few small things around the CI pipeline.

I added a suggestion above to fix the pre-commit job

The commit lint jobs are failing because the commit message is 6 characters longer than expected. Could you please amend the commit message to the expected length since this is parsed for the changelog.

Error: You have commit messages with errors

⧗   input: feat(pkgrepo): update logic following the migration to `packages.broadcom.com`
✖   header must not be longer than 72 characters, current length is 78 [header-max-length]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

https://github.com/saltstack-formulas/salt-formula/actions/runs/11830833414/job/32965007118?pr=566

I plan to take a closer look at this soon.

@sticky-note sticky-note force-pushed the feat/repos branch 2 times, most recently from b25c12d to 56a10e7 Compare November 14, 2024 05:50
@sticky-note sticky-note changed the title feat(pkgrepo): update logic following the migration to packages.broadcom.com feat(pkgrepo): impl new logic after migration to packages.broadcom.com Nov 14, 2024
@sticky-note
Copy link
Member Author

sticky-note commented Nov 14, 2024

@sticky-note Thank you for taking the time to put this together. I was able to give it a quick look at it now and noticed a few small things around the CI pipeline.

I added a suggestion above to fix the pre-commit job

The commit lint jobs are failing because the commit message is 6 characters longer than expected. Could you please amend the commit message to the expected length since this is parsed for the changelog.

Error: You have commit messages with errors

⧗   input: feat(pkgrepo): update logic following the migration to `packages.broadcom.com`
✖   header must not be longer than 72 characters, current length is 78 [header-max-length]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

https://github.com/saltstack-formulas/salt-formula/actions/runs/11830833414/job/32965007118?pr=566

I plan to take a closer look at this soon.

Done. Sorry for that. I am actually Testing for Debian 12, Ubuntu 24.04, AlmaLinux 9, rocky 9
I will confirm if it works for these cases

Do I need to do something for SLES, OpenSUSE or the binaries are managed by them ?

@sticky-note sticky-note requested a review from jeff350 November 14, 2024 06:01
@sticky-note sticky-note force-pushed the feat/repos branch 4 times, most recently from 346a997 to 5535039 Compare November 14, 2024 07:34
salt/osfamilymap.yaml Outdated Show resolved Hide resolved
pillar.example Outdated Show resolved Hide resolved
@jeff350
Copy link

jeff350 commented Nov 16, 2024

Looking at the CI jobs it appears that py_ver_repr was removed somewhere where it shouldn't have been and it is now causing rendering issues in the SLS files.

https://gitlab.com/saltstack-formulas/salt-formula/-/jobs/8376038655

@sticky-note
Copy link
Member Author

sticky-note commented Nov 19, 2024

Looking at the CI jobs it appears that py_ver_repr was removed somewhere where it shouldn't have been and it is now causing rendering issues in the SLS files.

https://gitlab.com/saltstack-formulas/salt-formula/-/jobs/8376038655

@jeff350 @sir-ragna
Corrected the mistyping, Sorry for that.

I confirm It is working on Ubuntu 22.04, Debian 12, Almalinux 9 with salt 3007.1
Maybe, there are some work to do for the repo management on RedHat by this formula, maybe it can be done later.

Don't know how to test with SUSE, OpenSUSE

@sticky-note sticky-note merged commit bf52207 into saltstack-formulas:master Dec 3, 2024
7 of 31 checks passed
@sticky-note sticky-note deleted the feat/repos branch December 3, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants