Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate is broken if salt is not installed. #201

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ldav1s
Copy link

@ldav1s ldav1s commented Jan 31, 2020

No description provided.

@nicholasmhughes
Copy link
Collaborator

Howdy! 👋

Apologies for the long delay on this integrating this code. We certainly appreciate your effort!

Pepper is getting some renewed focus and love, and we're checking in to see if you'd like to update this against the latest version of the base branch and ensure that all merge conditions are met.

If the items addressed by this contribution have already been fixed/added, are no longer an issue, or you no longer have a desire to work on this... please let us know and/or close out this PR.

If we don't hear from you within 7 days, we'll assume the code has been abandoned and close it out. If you'd like to revisit this in the future, you can always open a new PR.

Thank you, and we hope to see you active in the Salt ecosystem in the future!

@ldav1s
Copy link
Author

ldav1s commented Apr 26, 2023

I think this branch is up to date with the develop branch of pepper.

@barneysowood
Copy link
Collaborator

@ldav1s - thanks for responding. I've just finished fixing the test suite and migrating it to Github Actions. Would you be able to update your branch now please?

Could you also add some tests? If you need some help with that, please let me know.

Thanks very much!

@ldav1s
Copy link
Author

ldav1s commented May 6, 2023

Could you also add some tests? If you need some help with that, please let me know.

I'd have to have some kind of special environment or something to keep salt.loader, salt.config, and salt.output from being imported while under test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants