New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: rewrite #154

Open

saltydk opened this issue Jul 5, 2023 · 0 comments

Member

saltydk commented Jul 5, 2023

Clean up the settings role to use dynamic include_tasks instead of the current implementation that is fairly spammy and confusing to debug.

Current implementation:

- name: "Settings | Migrator"
  ansible.builtin.include_tasks: "subtasks/migrator.yml"
  vars:
    file: "{{ outer_item }}"

Initial suggestion would be:

- name: "Settings | Migrator"
  ansible.builtin.include_tasks: "subtasks/migrator/{{ outer_item }}.yml"

This would avoid looping over tasks that aren't going to do anything over and over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment